Commit 21b75827 authored May 19, 2020 by Miquel Raynal

mtd: rawnand: lpc32xx_slc: Stop using nand_release()



This helper is not very useful and very often people get confused:
they use nand_release() instead of nand_cleanup().

Let's stop using nand_release() by calling mtd_device_unregister() and
nand_cleanup() directly.

Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20200519130035.1883-25-miquel.raynal@bootlin.com

parent 5f3bce3a

drivers/mtd/nand/raw/lpc32xx_slc.c

+5 −1

Original line number	Diff line number	Diff line
		@@ -947,8 +947,12 @@ static int lpc32xx_nand_remove(struct platform_device *pdev)
		{
		uint32_t tmp;
		struct lpc32xx_nand_host *host = platform_get_drvdata(pdev);
		struct nand_chip *chip = &host->nand_chip;
		int ret;

		nand_release(&host->nand_chip);
		ret = mtd_device_unregister(nand_to_mtd(chip));
		WARN_ON(ret);
		nand_cleanup(chip);
		dma_release_channel(host->dma_chan);

		/* Force CE high */

Admin message