Commit 5f3bce3a authored May 19, 2020 by Miquel Raynal

mtd: rawnand: lpc32xx_mlc: Stop using nand_release()



This helper is not very useful and very often people get confused:
they use nand_release() instead of nand_cleanup().

Let's stop using nand_release() by calling mtd_device_unregister() and
nand_cleanup() directly.

Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20200519130035.1883-24-miquel.raynal@bootlin.com

parent 28dcc4e8

drivers/mtd/nand/raw/lpc32xx_mlc.c

+6 −1

Original line number	Diff line number	Diff line
		@@ -826,8 +826,13 @@ free_gpio:
		static int lpc32xx_nand_remove(struct platform_device *pdev)
		{
		struct lpc32xx_nand_host *host = platform_get_drvdata(pdev);
		struct nand_chip *chip = &host->nand_chip;
		int ret;

		ret = mtd_device_unregister(nand_to_mtd(chip));
		WARN_ON(ret);
		nand_cleanup(chip);

		nand_release(&host->nand_chip);
		free_irq(host->irq, host);
		if (use_dma)
		dma_release_channel(host->dma_chan);

Admin message