Commit 5b38e747 authored by Daniel Vetter's avatar Daniel Vetter
Browse files

drm/irq: Don't check for DRIVER_HAVE_IRQ in drm_irq_(un)install 



If a non-legacy driver calls these it's valid to assume there is
interrupt support. The flag is really only needed for legacy drivers,
which control IRQ enabling/disabling through the DRM_IOCTL_CONTROL
legacy IOCTL.

Also remove all the flag usage from non-legacy drivers.

v2: Review from Emil:
- improve commit message
- I forgot hibmc, fix that

Cc: linux-arm-kernel@lists.infradead.org
Cc: intel-gfx@lists.freedesktop.org
Cc: linux-amlogic@lists.infradead.org
Cc: linux-arm-msm@vger.kernel.org
Cc: freedreno@lists.freedesktop.org
Cc: virtualization@lists.linux-foundation.org
Cc: spice-devel@lists.freedesktop.org
Cc: amd-gfx@lists.freedesktop.org
Cc: linux-renesas-soc@vger.kernel.org
Reviewed-by: default avatarEmil Velikov <emil.velikov@collabora.com>
Reviewed-by: default avatarSam Ravnborg <sam@ravnborg.org>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190129104248.26607-1-daniel.vetter@ffwll.ch
parent f12d0b91

drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c

+1 −1
Original line number Diff line number Diff line
@@ -1189,7 +1189,7 @@ amdgpu_get_crtc_scanout_position(struct drm_device *dev, unsigned int pipe, 
static struct drm_driver kms_driver = {

	.driver_features =

	    DRIVER_USE_AGP | DRIVER_ATOMIC |

	    DRIVER_HAVE_IRQ | DRIVER_IRQ_SHARED | DRIVER_GEM |

	    DRIVER_IRQ_SHARED | DRIVER_GEM |

	    DRIVER_PRIME | DRIVER_RENDER | DRIVER_MODESET | DRIVER_SYNCOBJ,

	.load = amdgpu_driver_load_kms,

	.open = amdgpu_driver_open_kms,

drivers/gpu/drm/arm/hdlcd_drv.c

+1 −1
Original line number Diff line number Diff line
@@ -229,7 +229,7 @@ static int hdlcd_debugfs_init(struct drm_minor *minor) 
DEFINE_DRM_GEM_CMA_FOPS(fops);



static struct drm_driver hdlcd_driver = {

	.driver_features = DRIVER_HAVE_IRQ | DRIVER_GEM |

	.driver_features = DRIVER_GEM |

			   DRIVER_MODESET | DRIVER_PRIME |

			   DRIVER_ATOMIC,

	.irq_handler = hdlcd_irq,

drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c

+1 −1
Original line number Diff line number Diff line
@@ -720,7 +720,7 @@ static void atmel_hlcdc_dc_irq_uninstall(struct drm_device *dev) 
DEFINE_DRM_GEM_CMA_FOPS(fops);



static struct drm_driver atmel_hlcdc_dc_driver = {

	.driver_features = DRIVER_HAVE_IRQ | DRIVER_GEM |

	.driver_features = DRIVER_GEM |

			   DRIVER_MODESET | DRIVER_PRIME |

			   DRIVER_ATOMIC,

	.irq_handler = atmel_hlcdc_dc_irq_handler,

drivers/gpu/drm/drm_irq.c

+0 −6
Original line number Diff line number Diff line
@@ -103,9 +103,6 @@ int drm_irq_install(struct drm_device *dev, int irq) 
	int ret;

	unsigned long sh_flags = 0;



	if (!drm_core_check_feature(dev, DRIVER_HAVE_IRQ))

		return -EOPNOTSUPP;



	if (irq == 0)

		return -EINVAL;
@@ -174,9 +171,6 @@ int drm_irq_uninstall(struct drm_device *dev) 
	bool irq_enabled;

	int i;



	if (!drm_core_check_feature(dev, DRIVER_HAVE_IRQ))

		return -EOPNOTSUPP;



	irq_enabled = dev->irq_enabled;

	dev->irq_enabled = false;

drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c

+1 −1
Original line number Diff line number Diff line
@@ -137,7 +137,7 @@ static irqreturn_t fsl_dcu_drm_irq(int irq, void *arg) 
DEFINE_DRM_GEM_CMA_FOPS(fsl_dcu_drm_fops);



static struct drm_driver fsl_dcu_drm_driver = {

	.driver_features	= DRIVER_HAVE_IRQ | DRIVER_GEM | DRIVER_MODESET

	.driver_features	= DRIVER_GEM | DRIVER_MODESET

				| DRIVER_PRIME | DRIVER_ATOMIC,

	.load			= fsl_dcu_load,

	.unload			= fsl_dcu_unload,

CRA Git | Maintained and supported by SUSTech CRA and CCSE