drm/<drivers>: Don't set FBINFO_(FLAG_)DEFAULT (f12d0b91) · Commits · 戴 / test

Both macros evaluate to 0. At the same time flag is already set to zero since the struct is kzalloc'd in framebuffer_alloc(). As called by drm_fb_helper_alloc_fbi() in the DRM drivers. v2: Rebase and improve commit message per Emil's suggestion. Signed-off-by:

Daniel Vetter <daniel.vetter@intel.com> Cc: Inki Dae <inki.dae@samsung.com> Cc: Joonyoung Shim <jy0922.shim@samsung.com> Cc: Seung-Woo Kim <sw0312.kim@samsung.com> Cc: Kyungmin Park <kyungmin.park@samsung.com> Cc: Kukjin Kim <kgene@kernel.org> Cc: Krzysztof Kozlowski <krzk@kernel.org> Cc: Patrik Jakobsson <patrik.r.jakobsson@gmail.com> Cc: Ben Skeggs <bskeggs@redhat.com> Cc: Sandy Huang <hjc@rock-chips.com> Cc: "Heiko Stübner" <heiko@sntech.de> Cc: Thierry Reding <thierry.reding@gmail.com> Cc: Jonathan Hunter <jonathanh@nvidia.com> Cc: Hans de Goede <hdegoede@redhat.com> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Daniel Vetter <daniel.vetter@ffwll.ch> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> Cc: Alexander Kapshuk <alexander.kapshuk@gmail.com> Cc: linux-arm-kernel@lists.infradead.org Cc: linux-samsung-soc@vger.kernel.org Cc: nouveau@lists.freedesktop.org Cc: linux-rockchip@lists.infradead.org Cc: linux-tegra@vger.kernel.org Reviewed-by:

Emil Velikov <emil.l.velikov@gmail.com> Acked-by:

Thierry Reding <treding@nvidia.com> Link: https://patchwork.freedesktop.org/patch/msgid/20190124165831.16427-27-daniel.vetter@ffwll.ch

drivers/gpu/drm/exynos/exynos_drm_fbdev.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -88,7 +88,6 @@ static int exynos_drm_fbdev_update(struct drm_fb_helper *helper,
		}

		fbi->par = helper;
		fbi->flags = FBINFO_FLAG_DEFAULT;
		fbi->fbops = &exynos_drm_fb_ops;

		drm_fb_helper_fill_fix(fbi, fb->pitches[0], fb->format->depth);

drivers/gpu/drm/gma500/framebuffer.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -405,7 +405,6 @@ static int psbfb_create(struct psb_fbdev *fbdev,
		drm_fb_helper_fill_fix(info, fb->pitches[0], fb->format->depth);
		strcpy(info->fix.id, "psbdrmfb");

		info->flags = FBINFO_DEFAULT;
		if (dev_priv->ops->accel_2d && pitch_lines > 8) /* 2D engine */
		info->fbops = &psbfb_ops;
		else if (gtt_roll) { /* GTT rolling seems best */

drivers/gpu/drm/nouveau/nouveau_fbcon.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -374,9 +374,9 @@ nouveau_fbcon_create(struct drm_fb_helper *helper,

		strcpy(info->fix.id, "nouveaufb");
		if (!chan)
		info->flags = FBINFO_DEFAULT \| FBINFO_HWACCEL_DISABLED;
		info->flags = FBINFO_HWACCEL_DISABLED;
		else
		info->flags = FBINFO_DEFAULT \| FBINFO_HWACCEL_COPYAREA \|
		info->flags = FBINFO_HWACCEL_COPYAREA \|
		FBINFO_HWACCEL_FILLRECT \|
		FBINFO_HWACCEL_IMAGEBLIT;
		info->fbops = &nouveau_fbcon_sw_ops;

drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -91,7 +91,6 @@ static int rockchip_drm_fbdev_create(struct drm_fb_helper *helper,
		}

		fbi->par = helper;
		fbi->flags = FBINFO_FLAG_DEFAULT;
		fbi->fbops = &rockchip_drm_fbdev_ops;

		fb = helper->fb;

drivers/gpu/drm/tegra/fb.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -256,7 +256,6 @@ static int tegra_fbdev_probe(struct drm_fb_helper *helper,
		helper->fbdev = info;

		info->par = helper;
		info->flags = FBINFO_FLAG_DEFAULT;
		info->fbops = &tegra_fb_ops;

		drm_fb_helper_fill_fix(info, fb->pitches[0], fb->format->depth);

Admin message