Commit 58af272b authored Mar 22, 2017 by Tobin C. Harding Committed by Greg Kroah-Hartman Mar 23, 2017

staging: ks7010: fix memcmp() bug



Call site to memcmp() treats return value as if it were an error code,
it is not. If memcmp() finds inputs to be not the same, an error
return code should be set explicitly.

Correctly handle return value from call to memcmp(), set error code
explicitly.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Tobin C. Harding <me@tobin.cc>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 12eed2f2

drivers/staging/ks7010/ks7010_sdio.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -695,8 +695,8 @@ static int ks7010_sdio_data_compare(struct ks_wlan_private *priv, u32 address,
		if (ret)
		goto err_free_read_buf;

		ret = memcmp(data, read_buf, size);
		if (ret) {
		if (memcmp(data, read_buf, size) != 0) {
		ret = -EIO;
		DPRINTK(0, "data compare error (%d)\n", ret);
		goto err_free_read_buf;
		}

Admin message