Commit 5611ec2b authored Jul 24, 2020 by Kai-Heng Feng Committed by Christoph Hellwig Jul 26, 2020

nvme-pci: prevent SK hynix PC400 from using Write Zeroes command

After commit 6e02318e ("nvme: add support for the Write Zeroes
command"), SK hynix PC400 becomes very slow with the following error
message:

[  224.567695] blk_update_request: operation not supported error, dev nvme1n1, sector 499384320 op 0x9:(WRITE_ZEROES) flags 0x1000000 phys_seg 0 prio class 0]

SK Hynix PC400 has a buggy firmware that treats NLB as max value instead
of a range, so the NLB passed isn't a valid value to the firmware.

According to SK hynix there are three commands are affected:
- Write Zeroes
- Compare
- Write Uncorrectable

Right now only Write Zeroes is implemented, so disable it completely on
SK hynix PC400.

BugLink: https://bugs.launchpad.net/bugs/1872383


Cc: kyounghwan sohn <kyounghwan.sohn@sk.com>
Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>

parent adc99fd3

drivers/nvme/host/pci.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -3122,6 +3122,8 @@ static const struct pci_device_id nvme_id_table[] = {
		{ PCI_DEVICE(0x1cc1, 0x8201), /* ADATA SX8200PNP 512GB */
		.driver_data = NVME_QUIRK_NO_DEEPEST_PS \|
		NVME_QUIRK_IGNORE_DEV_SUBNQN, },
		{ PCI_DEVICE(0x1c5c, 0x1504), /* SK Hynix PC400 */
		.driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES, },
		{ PCI_DEVICE_CLASS(PCI_CLASS_STORAGE_EXPRESS, 0xffffff) },
		{ PCI_DEVICE(PCI_VENDOR_ID_APPLE, 0x2001),
		.driver_data = NVME_QUIRK_SINGLE_VECTOR },

Admin message