Commit adc99fd3 authored Jul 23, 2020 by Sagi Grimberg Committed by Christoph Hellwig Jul 26, 2020

nvme-tcp: fix possible hang waiting for icresp response



If the controller died exactly when we are receiving icresp
we hang because icresp may never return. Make sure to set a
high finite limit.

Fixes: 3f2304f8 ("nvme-tcp: add NVMe over TCP host driver")
Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Christoph Hellwig <hch@lst.de>

parent 1f273e25

drivers/nvme/host/tcp.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -1382,6 +1382,9 @@ static int nvme_tcp_alloc_queue(struct nvme_ctrl *nctrl,
		if (nctrl->opts->tos >= 0)
		ip_sock_set_tos(queue->sock->sk, nctrl->opts->tos);

		/* Set 10 seconds timeout for icresp recvmsg */
		queue->sock->sk->sk_rcvtimeo = 10 * HZ;

		queue->sock->sk->sk_allocation = GFP_ATOMIC;
		nvme_tcp_set_queue_io_cpu(queue);
		queue->request = NULL;

Admin message