Commit 547c8788 authored Jun 30, 2020 by Alex Elder Committed by David S. Miller Jul 01, 2020

net: ipa: HOL_BLOCK_EN_FMASK is a 1-bit mask



The convention throughout the IPA driver is to directly use
single-bit field mask values, rather than using (for example)
u32_encode_bits() to set or clear them.

Fix the one place that doesn't follow that convention, which sets
HOL_BLOCK_EN_FMASK in ipa_endpoint_init_hol_block_enable().

Signed-off-by: Alex Elder <elder@linaro.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 8b97bcb7

drivers/net/ipa/ipa_endpoint.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -674,7 +674,7 @@ ipa_endpoint_init_hol_block_enable(struct ipa_endpoint *endpoint, bool enable)
		u32 offset;
		u32 val;

		val = u32_encode_bits(enable ? 1 : 0, HOL_BLOCK_EN_FMASK);
		val = enable ? HOL_BLOCK_EN_FMASK : 0;
		offset = IPA_REG_ENDP_INIT_HOL_BLOCK_EN_N_OFFSET(endpoint_id);
		iowrite32(val, endpoint->ipa->reg_virt + offset);
		}

Admin message