Commit 544bac89 authored by Miquel Raynal's avatar Miquel Raynal
Browse files

mtd: rawnand: cafe: Stop using nand_release() 



This helper is not very useful and very often people get confused:
they use nand_release() instead of nand_cleanup().

Let's stop using nand_release() by calling mtd_device_unregister() and
nand_cleanup() directly.

Signed-off-by: default avatarMiquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20200519130035.1883-7-miquel.raynal@bootlin.com
parent 8b88f4e0

drivers/mtd/nand/raw/cafe_nand.c

+4 −1
Original line number Diff line number Diff line
@@ -807,11 +807,14 @@ static void cafe_nand_remove(struct pci_dev *pdev) 
	struct mtd_info *mtd = pci_get_drvdata(pdev);

	struct nand_chip *chip = mtd_to_nand(mtd);

	struct cafe_priv *cafe = nand_get_controller_data(chip);

	int ret;



	/* Disable NAND IRQ in global IRQ mask register */

	cafe_writel(cafe, ~1 & cafe_readl(cafe, GLOBAL_IRQ_MASK), GLOBAL_IRQ_MASK);

	free_irq(pdev->irq, mtd);

	nand_release(chip);

	ret = mtd_device_unregister(mtd);

	WARN_ON(ret);

	nand_cleanup(chip);

	free_rs(cafe->rs);

	pci_iounmap(pdev, cafe->mmio);

	dma_free_coherent(&cafe->pdev->dev, 2112, cafe->dmabuf, cafe->dmaaddr);

CRA Git | Maintained and supported by SUSTech CRA and CCSE