mtd: rawnand: cadence: Stop using nand_release() (8b88f4e0) · Commits · 戴 / test

This helper is not very useful and very often people get confused: they use nand_release() instead of nand_cleanup(). Let's stop using nand_release() by calling mtd_device_unregister() and nand_cleanup() directly. Signed-off-by:

Miquel Raynal <miquel.raynal@bootlin.com> Link: https://lore.kernel.org/linux-mtd/20200519130035.1883-6-miquel.raynal@bootlin.com

drivers/mtd/nand/raw/cadence-nand-controller.c

+6 −1

Original line number	Diff line number	Diff line
		@@ -2780,9 +2780,14 @@ static int cadence_nand_chip_init(struct cdns_nand_ctrl *cdns_ctrl,
		static void cadence_nand_chips_cleanup(struct cdns_nand_ctrl *cdns_ctrl)
		{
		struct cdns_nand_chip entry, temp;
		struct nand_chip *chip;
		int ret;

		list_for_each_entry_safe(entry, temp, &cdns_ctrl->chips, node) {
		nand_release(&entry->chip);
		chip = &entry->chip;
		ret = mtd_device_unregister(nand_to_mtd(chip));
		WARN_ON(ret);
		nand_cleanup(chip);
		list_del(&entry->node);
		}
		}

Admin message