Commit 53dd5c70 authored Apr 30, 2019 by Gustavo A. R. Silva Committed by Stephen Boyd May 03, 2019

clk: imx: clk-pllv3: mark expected switch fall-throughs



In preparation to enabling -Wimplicit-fallthrough, mark switch
cases where we are expecting to fall through.

This patch fixes the following warnings:

drivers/clk/imx/clk-pllv3.c: In function ‘imx_clk_pllv3’:
drivers/clk/imx/clk-pllv3.c:446:18: warning: this statement may fall through [-Wimplicit-fallthrough=]
   pll->div_shift = 1;
   ~~~~~~~~~~~~~~~^~~
drivers/clk/imx/clk-pllv3.c:447:2: note: here
  case IMX_PLLV3_USB:
  ^~~~
drivers/clk/imx/clk-pllv3.c:453:21: warning: this statement may fall through [-Wimplicit-fallthrough=]
   pll->denom_offset = PLL_IMX7_DENOM_OFFSET;
                     ^
drivers/clk/imx/clk-pllv3.c:454:2: note: here
  case IMX_PLLV3_AV:
  ^~~~

Warning level 3 was used: -Wimplicit-fallthrough=3

This patch is part of the ongoing efforts to enable
-Wimplicit-fallthrough.

Fixes: b4a4cb5a ("clk: imx: correct i.MX7D AV PLL num/denom offset")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: Anson Huang <Anson.Huang@nxp.com>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>

parent 4d13c67a

drivers/clk/imx/clk-pllv3.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -444,6 +444,7 @@ struct clk imx_clk_pllv3(enum imx_pllv3_type type, const char name,
		break;
		case IMX_PLLV3_USB_VF610:
		pll->div_shift = 1;
		/* fall through */
		case IMX_PLLV3_USB:
		ops = &clk_pllv3_ops;
		pll->powerup_set = true;
		@@ -451,6 +452,7 @@ struct clk imx_clk_pllv3(enum imx_pllv3_type type, const char name,
		case IMX_PLLV3_AV_IMX7:
		pll->num_offset = PLL_IMX7_NUM_OFFSET;
		pll->denom_offset = PLL_IMX7_DENOM_OFFSET;
		/* fall through */
		case IMX_PLLV3_AV:
		ops = &clk_pllv3_av_ops;
		break;

Admin message