Commit 53a3c448 authored Oct 26, 2010 by Andy Whitcroft Committed by Linus Torvalds Oct 26, 2010

checkpatch: returning errno typically should be negative



Add a (strict mode only) test to check for non-negative returns of what
appear to be errno values as the majority case these should indeed be
negative.

Suggested-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Andy Whitcroft <apw@canonical.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 9446ef56

scripts/checkpatch.pl

+7 −0

Original line number	Diff line number	Diff line
		@@ -2204,6 +2204,13 @@ sub process {
		ERROR("space required before the open parenthesis '('\n" . $herecurr);
		}
		}
		# Return of what appears to be an errno should normally be -'ve
		if ($line =~ /^.\sreturn\s(E[A-Z])\s;/) {
		my $name = $1;
		if ($name ne 'EOF' && $name ne 'ERROR') {
		WARN("return of an errno should typically be -ve (return -$1)\n" . $herecurr);
		}
		}

		# Need a space before open parenthesis after if, while etc
		if ($line=~/\b(if\|while\|for\|switch)\(/) {

Admin message