Commit 9446ef56 authored Oct 26, 2010 by Andy Whitcroft Committed by Linus Torvalds Oct 26, 2010

checkpatch: handle casts better fixing false categorisation of : as binary



The following incantation is triggering categorisation of its colon (:) as
a binary form, which it is not:

	return foo ? (s8)bar : baz;

Handle casts differently from types in the categoriser, allowing us to
better track (s8)bar as a value and not a declaration.

Reported-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Andy Whitcroft <apw@canonical.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent fb2d2c1b

scripts/checkpatch.pl

+5 −0

Original line number	Diff line number	Diff line
		@@ -845,6 +845,11 @@ sub annotate_values {
		$av_preprocessor = 0;
		}

		} elsif ($cur =~ /^($\s$Type\s)$/) {
		print "CAST($1)\n" if ($dbg_values > 1);
		push(@av_paren_type, $type);
		$type = 'C';

		} elsif ($cur =~ /^($Type)\s(?:$Ident\|,\|\)\|\(\|\s$)/) {
		print "DECLARE($1)\n" if ($dbg_values > 1);
		$type = 'T';

Admin message