Commit 52553ddf authored Nov 27, 2011 by Edward Donovan Committed by Linus Torvalds Nov 28, 2011

genirq: fix regression in irqfixup, irqpoll



Commit fa27271b("genirq: Fixup poll handling") introduced a
regression that broke irqfixup/irqpoll for some hardware configurations.

Amidst reorganizing 'try_one_irq', that patch removed a test that
checked for 'action->handler' returning IRQ_HANDLED, before acting on
the interrupt.  Restoring this test back returns the functionality lost
since 2.6.39.  In the current set of tests, after 'action' is set, it
must precede '!action->next' to take effect.

With this and my previous patch to irq/spurious.c, c75d720f, all
IRQ regressions that I have encountered are fixed.

Signed-off-by: Edward Donovan <edward.donovan@numble.net>
Reported-and-tested-by: Rogério Brito <rbrito@ime.usp.br>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: stable@kernel.org (2.6.39+)
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 401d0069

kernel/irq/spurious.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -84,7 +84,9 @@ static int try_one_irq(int irq, struct irq_desc *desc, bool force)
		*/
		action = desc->action;
		if (!action \|\| !(action->flags & IRQF_SHARED) \|\|
		(action->flags & __IRQF_TIMER) \|\| !action->next)
		(action->flags & __IRQF_TIMER) \|\|
		(action->handler(irq, action->dev_id) == IRQ_HANDLED) \|\|
		!action->next)
		goto out;

		/* Already running on another processor */

Admin message