Commit c75d720f authored Nov 01, 2011 by Edward Donovan Committed by Thomas Gleixner Nov 03, 2011

genirq: Fix irqfixup, irqpoll regression



commit d05c65ff ("genirq: spurious: Run only one poller at a time")
introduced a regression, leaving the boot options 'irqfixup' and
'irqpoll' non-functional. The patch placed tests in each function, to
exit if the function is already running. The test in 'misrouted_irq'
exited when it should have proceeded, effectively disabling
'misrouted_irq' and 'poll_spurious_irqs'.

The check for an already running poller needs to be "!= 1" not "== 1"
as "1" is the value when the first poller starts running.

Signed-off-by: Edward Donovan <edward.donovan@numble.net>
Cc: maciej.rutecki@gmail.com
Link: http://lkml.kernel.org/r/1320175784-6745-1-git-send-email-edward.donovan@numble.net


Cc: stable@vger.kernel.org # >= 2.6.39
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

parent c3b92c87

kernel/irq/spurious.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -115,7 +115,7 @@ static int misrouted_irq(int irq)
		struct irq_desc *desc;
		int i, ok = 0;

		if (atomic_inc_return(&irq_poll_active) == 1)
		if (atomic_inc_return(&irq_poll_active) != 1)
		goto out;

		irq_poll_cpu = smp_processor_id();

Admin message