Commit 4cb760b0 authored by Richard Henderson's avatar Richard Henderson Committed by Theodore Ts'o
Browse files

s390x: Mark archrandom.h functions __must_check 



We must not use the pointer output without validating the
success of the random read.

Reviewed-by: default avatarHarald Freudenberger <freude@linux.ibm.com>
Reviewed-by: default avatarArd Biesheuvel <ardb@kernel.org>
Signed-off-by: default avatarRichard Henderson <rth@twiddle.net>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
Link: https://lore.kernel.org/r/20200110145422.49141-11-broonie@kernel.org


Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
parent 8dae77ac

arch/s390/include/asm/archrandom.h

+4 −4
Original line number Diff line number Diff line
@@ -21,17 +21,17 @@ extern atomic64_t s390_arch_random_counter; 


bool s390_arch_random_generate(u8 *buf, unsigned int nbytes);



static inline bool arch_get_random_long(unsigned long *v)

static inline bool __must_check arch_get_random_long(unsigned long *v)

{

	return false;

}



static inline bool arch_get_random_int(unsigned int *v)

static inline bool __must_check arch_get_random_int(unsigned int *v)

{

	return false;

}



static inline bool arch_get_random_seed_long(unsigned long *v)

static inline bool __must_check arch_get_random_seed_long(unsigned long *v)

{

	if (static_branch_likely(&s390_arch_random_available)) {

		return s390_arch_random_generate((u8 *)v, sizeof(*v));
@@ -39,7 +39,7 @@ static inline bool arch_get_random_seed_long(unsigned long *v) 
	return false;

}



static inline bool arch_get_random_seed_int(unsigned int *v)

static inline bool __must_check arch_get_random_seed_int(unsigned int *v)

{

	if (static_branch_likely(&s390_arch_random_available)) {

		return s390_arch_random_generate((u8 *)v, sizeof(*v));

CRA Git | Maintained and supported by SUSTech CRA and CCSE