Commit 8dae77ac authored by Richard Henderson's avatar Richard Henderson Committed by Theodore Ts'o
Browse files

powerpc: Mark archrandom.h functions __must_check 



We must not use the pointer output without validating the
success of the random read.

Acked-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
Reviewed-by: default avatarArd Biesheuvel <ardb@kernel.org>
Signed-off-by: default avatarRichard Henderson <rth@twiddle.net>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
Link: https://lore.kernel.org/r/20200110145422.49141-10-broonie@kernel.org


Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
parent 98dcfce6

arch/powerpc/include/asm/archrandom.h

+4 −4
Original line number Diff line number Diff line
@@ -6,17 +6,17 @@ 


#include <asm/machdep.h>



static inline bool arch_get_random_long(unsigned long *v)

static inline bool __must_check arch_get_random_long(unsigned long *v)

{

	return false;

}



static inline bool arch_get_random_int(unsigned int *v)

static inline bool __must_check arch_get_random_int(unsigned int *v)

{

	return false;

}



static inline bool arch_get_random_seed_long(unsigned long *v)

static inline bool __must_check arch_get_random_seed_long(unsigned long *v)

{

	if (ppc_md.get_random_seed)

		return ppc_md.get_random_seed(v);
@@ -24,7 +24,7 @@ static inline bool arch_get_random_seed_long(unsigned long *v) 
	return false;

}



static inline bool arch_get_random_seed_int(unsigned int *v)

static inline bool __must_check arch_get_random_seed_int(unsigned int *v)

{

	unsigned long val;

	bool rc;

CRA Git | Maintained and supported by SUSTech CRA and CCSE