Commit 4c5681fc authored by Florian Fainelli's avatar Florian Fainelli Committed by Viresh Kumar
Browse files

cpufreq: brcmstb-avs-cpufreq: Fix types for voltage/frequency 



What we read back from the register is going to be capped at 32-bits,
and cpufreq_freq_table.frequency is an unsigned int. Avoid any possible
value truncation by using the appropriate return value.

Fixes: de322e08 ("cpufreq: brcmstb-avs-cpufreq: AVS CPUfreq driver for Broadcom STB SoCs")
Signed-off-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
Acked-by: default avatarMarkus Mayer <mmayer@broadcom.com>
Signed-off-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
parent 22a26cc6

drivers/cpufreq/brcmstb-avs-cpufreq.c

+4 −4
Original line number Diff line number Diff line
@@ -384,12 +384,12 @@ static int brcm_avs_set_pstate(struct private_data *priv, unsigned int pstate) 
	return __issue_avs_command(priv, AVS_CMD_SET_PSTATE, true, args);

}



static unsigned long brcm_avs_get_voltage(void __iomem *base)

static u32 brcm_avs_get_voltage(void __iomem *base)

{

	return readl(base + AVS_MBOX_VOLTAGE1);

}



static unsigned long brcm_avs_get_frequency(void __iomem *base)

static u32 brcm_avs_get_frequency(void __iomem *base)

{

	return readl(base + AVS_MBOX_FREQUENCY) * 1000;	/* in kHz */

}
@@ -653,14 +653,14 @@ static ssize_t show_brcm_avs_voltage(struct cpufreq_policy *policy, char *buf) 
{

	struct private_data *priv = policy->driver_data;



	return sprintf(buf, "0x%08lx\n", brcm_avs_get_voltage(priv->base));

	return sprintf(buf, "0x%08x\n", brcm_avs_get_voltage(priv->base));

}



static ssize_t show_brcm_avs_frequency(struct cpufreq_policy *policy, char *buf)

{

	struct private_data *priv = policy->driver_data;



	return sprintf(buf, "0x%08lx\n", brcm_avs_get_frequency(priv->base));

	return sprintf(buf, "0x%08x\n", brcm_avs_get_frequency(priv->base));

}



cpufreq_freq_attr_ro(brcm_avs_pstate);

CRA Git | Maintained and supported by SUSTech CRA and CCSE