Commit 22a26cc6 authored May 22, 2019 by Florian Fainelli Committed by Viresh Kumar Jun 04, 2019

cpufreq: brcmstb-avs-cpufreq: Fix initial command check



There is a logical error in brcm_avs_is_firmware_loaded() whereby if the
firmware returns -EINVAL, we will be reporting this as an error. The
comment is correct, the code was not.

Fixes: de322e08 ("cpufreq: brcmstb-avs-cpufreq: AVS CPUfreq driver for Broadcom STB SoCs")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Acked-by: Markus Mayer <mmayer@broadcom.com>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>

parent 036eb5c6

drivers/cpufreq/brcmstb-avs-cpufreq.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -446,8 +446,8 @@ static bool brcm_avs_is_firmware_loaded(struct private_data *priv)
		rc = brcm_avs_get_pmap(priv, NULL);
		magic = readl(priv->base + AVS_MBOX_MAGIC);

		return (magic == AVS_FIRMWARE_MAGIC) && (rc != -ENOTSUPP) &&
		(rc != -EINVAL);
		return (magic == AVS_FIRMWARE_MAGIC) && ((rc != -ENOTSUPP) \|\|
		(rc != -EINVAL));
		}

		static unsigned int brcm_avs_cpufreq_get(unsigned int cpu)

Admin message