Unverified Commit 4b8a1ca4 authored Feb 14, 2020 by Tzung-Bi Shih Committed by Mark Brown Feb 14, 2020

ASoC: max98090: revert invalid fix for handling SHDN



Reverts commit 62d5ae4c ("ASoC: max98090: save and restore
SHDN when changing sensitive registers").

A critical side-effect was observed: when keep playing something,
the recorded sound has chance to break (clipping).

Signed-off-by: Tzung-Bi Shih <tzungbi@google.com>
Link: https://lore.kernel.org/r/20200214105744.82258-2-tzungbi@google.com


Signed-off-by: Mark Brown <broonie@kernel.org>

parent b6570fdb

sound/soc/codecs/max98090.c

+123 −311

File changed.

Preview size limit exceeded, changes collapsed.

sound/soc/codecs/max98090.h

+1 −2

Original line number	Diff line number	Diff line
		@@ -1539,8 +1539,7 @@ struct max98090_priv {
		unsigned int pa2en;
		unsigned int sidetone;
		bool master;
		int saved_count;
		int saved_shdn;
		bool shdn_pending;
		};

		int max98090_mic_detect(struct snd_soc_component *component,

Admin message