Unverified Commit b6570fdb authored Feb 13, 2020 by Samuel Holland Committed by Mark Brown Feb 13, 2020

ASoC: codec2codec: avoid invalid/double-free of pcm runtime



The PCM runtime was freed during PMU in the case that the event hook
encountered an error. However, it is also unconditionally freed during
PMD. Avoid a double-free by dropping the call to kfree in the PMU hook.

Fixes: a72706ed ("ASoC: codec2codec: remove ephemeral variables")
Cc: stable@vger.kernel.org
Signed-off-by: Samuel Holland <samuel@sholland.org>
Link: https://lore.kernel.org/r/20200213061147.29386-2-samuel@sholland.org


Signed-off-by: Mark Brown <broonie@kernel.org>

parent 1880b1f1

sound/soc/soc-dapm.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -3916,9 +3916,6 @@ snd_soc_dai_link_event_pre_pmu(struct snd_soc_dapm_widget *w,
		runtime->rate = params_rate(params);

		out:
		if (ret < 0)
		kfree(runtime);

		kfree(params);
		return ret;
		}

Admin message