Commit 48bbf637 authored May 07, 2020 by Gustavo A. R. Silva Committed by Chanwoo Choi May 28, 2020

PM / devfreq: imx-bus: Fix inconsistent IS_ERR and PTR_ERR



Fix inconsistent IS_ERR and PTR_ERR in imx_bus_init_icc().

The proper pointer to be passed as argument to PTR_ERR() is
priv->icc_pdev.

This bug was detected with the help of Coccinelle.

Fixes: 16c1d2f1b0bd ("PM / devfreq: imx: Register interconnect device")
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: Dong Aisheng <aisheng.dong@nxp.com>
[cw00.choi: Edit the patch title from 'imx' to 'imx-bus']
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>

parent a316b5ca

drivers/devfreq/imx-bus.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -88,8 +88,8 @@ static int imx_bus_init_icc(struct device *dev)
		dev, icc_driver_name, -1, NULL, 0);
		if (IS_ERR(priv->icc_pdev)) {
		dev_err(dev, "failed to register icc provider %s: %ld\n",
		icc_driver_name, PTR_ERR(priv->devfreq));
		return PTR_ERR(priv->devfreq);
		icc_driver_name, PTR_ERR(priv->icc_pdev));
		return PTR_ERR(priv->icc_pdev);
		}

		return 0;

Admin message