Commit a316b5ca authored Feb 27, 2020 by Dmitry Osipenko Committed by Chanwoo Choi May 28, 2020

PM / devfreq: Replace strncpy with strscpy

GCC produces this warning when kernel compiled using `make W=1`:

warning: ‘strncpy’ specified bound 16 equals destination size [-Wstringop-truncation]
772 | strncpy(devfreq->governor_name, governor_name, DEVFREQ_NAME_LEN);

The strncpy doesn't take care of NULL-termination of the destination
buffer, while the strscpy does.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>

parent 02355216

drivers/devfreq/devfreq.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -768,7 +768,7 @@ struct devfreq devfreq_add_device(struct device dev,
		devfreq->dev.release = devfreq_dev_release;
		INIT_LIST_HEAD(&devfreq->node);
		devfreq->profile = profile;
		strncpy(devfreq->governor_name, governor_name, DEVFREQ_NAME_LEN);
		strscpy(devfreq->governor_name, governor_name, DEVFREQ_NAME_LEN);
		devfreq->previous_freq = profile->initial_freq;
		devfreq->last_status.current_frequency = profile->initial_freq;
		devfreq->data = data;

Admin message