Commit 475d04b4 authored May 23, 2020 by Sudeep Holla

ARM: OMAP2: Use custom soc attribute group instead of device_create_file

Commit c31e7312 ("base: soc: Handle custom soc information sysfs
entries") introduced custom soc attribute group in soc_device_attribute
structure but there are no users treewide. While trying to understand
the motivation and tried to use it, it was found lot of existing custom
attributes can moved to use it instead of device_create_file.

Though most of these never remove/cleanup the custom attribute as they
never call soc_device_unregister, using these custom attribute group
eliminate the need for any cleanup as the driver infrastructure will
take care of that.

Let us remove device_create_file and start using the custom attribute
group in soc_device_attribute.

Link: https://lore.kernel.org/r/20200523170859.50003-9-sudeep.holla@arm.com


Cc: Tony Lindgren <tony@atomide.com>
Cc: linux-omap@vger.kernel.org
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Acked-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>

parent 53d421d2

arch/arm/mach-omap2/id.c

+8 −4

Original line number	Diff line number	Diff line
		@@ -783,9 +783,15 @@ type_show(struct device dev, struct device_attribute attr, char *buf)

		static DEVICE_ATTR_RO(type);

		static struct attribute *omap_soc_attrs[] = {
		&dev_attr_type.attr,
		NULL
		};

		ATTRIBUTE_GROUPS(omap_soc);

		void __init omap_soc_device_init(void)
		{
		struct device *parent;
		struct soc_device *soc_dev;
		struct soc_device_attribute *soc_dev_attr;

		@@ -796,14 +802,12 @@ void __init omap_soc_device_init(void)
		soc_dev_attr->machine = soc_name;
		soc_dev_attr->family = omap_get_family();
		soc_dev_attr->revision = soc_rev;
		soc_dev_attr->custom_attr_group = omap_soc_groups[0];

		soc_dev = soc_device_register(soc_dev_attr);
		if (IS_ERR(soc_dev)) {
		kfree(soc_dev_attr);
		return;
		}

		parent = soc_device_to_device(soc_dev);
		device_create_file(parent, &dev_attr_type);
		}
		#endif /* CONFIG_SOC_BUS */

Admin message