ARM: OMAP2: Switch to use DEVICE_ATTR_RO() (53d421d2) · Commits · 戴 / test

Move device attributes to DEVICE_ATTR_RO() as that would make things a lot more "obvious" what is happening over the existing __ATTR usage. Link: https://lore.kernel.org/r/20200523170859.50003-8-sudeep.holla@arm.com Cc: Tony Lindgren <tony@atomide.com> Cc: linux-omap@vger.kernel.org Reviewed-by:

Greg Kroah-Hartman <gregkh@linuxfoundation.org> Acked-by:

Tony Lindgren <tony@atomide.com> Signed-off-by:

Sudeep Holla <sudeep.holla@arm.com>

arch/arm/mach-omap2/id.c

+4 −6

Original line number	Diff line number	Diff line
		@@ -775,15 +775,13 @@ static const char * __init omap_get_family(void)
		return kasprintf(GFP_KERNEL, "Unknown");
		}

		static ssize_t omap_get_type(struct device *dev,
		struct device_attribute *attr,
		char *buf)
		static ssize_t
		type_show(struct device dev, struct device_attribute attr, char *buf)
		{
		return sprintf(buf, "%s\n", omap_types[omap_type()]);
		}

		static struct device_attribute omap_soc_attr =
		__ATTR(type, S_IRUGO, omap_get_type, NULL);
		static DEVICE_ATTR_RO(type);

		void __init omap_soc_device_init(void)
		{
		@@ -806,6 +804,6 @@ void __init omap_soc_device_init(void)
		}

		parent = soc_device_to_device(soc_dev);
		device_create_file(parent, &omap_soc_attr);
		device_create_file(parent, &dev_attr_type);
		}
		#endif /* CONFIG_SOC_BUS */

Admin message