Unverified Commit 46dce404 authored Nov 14, 2018 by Colin Ian King Committed by Mark Brown Nov 14, 2018

ASoC: amd: fix memory leak of i2s_data on error return



Currently when snd_pcm_hw_constraint_integer fails there is
a memory leak of i2s_data on the error return path. Fix this by
kfree'ing i2s_data before returning.

Detected by CoverityScan, CID#1475479 ("Resource leak")

Fixes: 0b87d6bc ("ASoC: amd: add acp3x pcm driver dma ops")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Mark Brown <broonie@kernel.org>

parent 9d4b17ef

sound/soc/amd/raven/acp3x-pcm-dma.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -309,6 +309,7 @@ static int acp3x_dma_open(struct snd_pcm_substream *substream)
		SNDRV_PCM_HW_PARAM_PERIODS);
		if (ret < 0) {
		dev_err(component->dev, "set integer constraint failed\n");
		kfree(i2s_data);
		return ret;
		}

Admin message