gpiolib: use gpiochip_get_desc() in lineevent_create() (45e23604) · Commits · 戴 / test

Unduplicate the ngpio check by simply calling gpiochip_get_desc() and checking its return value. Signed-off-by:

drivers/gpio/gpiolib.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -1009,8 +1009,9 @@ static int lineevent_create(struct gpio_device gdev, void __user ip)
		lflags = eventreq.handleflags;
		eflags = eventreq.eventflags;

		if (offset >= gdev->ngpio)
		return -EINVAL;
		desc = gpiochip_get_desc(gdev->chip, offset);
		if (IS_ERR(desc))
		return PTR_ERR(desc);

		/* Return an error if a unknown flag is set */
		if ((lflags & ~GPIOHANDLE_REQUEST_VALID_FLAGS) \|\|
		@@ -1048,7 +1049,6 @@ static int lineevent_create(struct gpio_device gdev, void __user ip)
		}
		}

		desc = &gdev->descs[offset];
		ret = gpiod_request(desc, le->label);
		if (ret)
		goto out_free_label;