gpiolib: use gpiochip_get_desc() in linehandle_create() (0f41dabe) · Commits · 戴 / test

Unduplicate the ngpio check by simply calling gpiochip_get_desc() and checking its return value. Signed-off-by:

drivers/gpio/gpiolib.c

+3 −4

Original line number	Diff line number	Diff line
		@@ -678,14 +678,13 @@ static int linehandle_create(struct gpio_device gdev, void __user ip)
		/* Request each GPIO */
		for (i = 0; i < handlereq.lines; i++) {
		u32 offset = handlereq.lineoffsets[i];
		struct gpio_desc *desc;
		struct gpio_desc *desc = gpiochip_get_desc(gdev->chip, offset);

		if (offset >= gdev->ngpio) {
		ret = -EINVAL;
		if (IS_ERR(desc)) {
		ret = PTR_ERR(desc);
		goto out_free_descs;
		}

		desc = &gdev->descs[offset];
		ret = gpiod_request(desc, lh->label);
		if (ret)
		goto out_free_descs;