Commit 44d51706 authored May 24, 2016 by Mikulas Patocka Committed by Linus Torvalds May 28, 2016

hpfs: fix remount failure when there are no options changed



Commit ce657611 ("hpfs: kstrdup() out of memory handling") checks if
the kstrdup function returns NULL due to out-of-memory condition.

However, if we are remounting a filesystem with no change to
filesystem-specific options, the parameter data is NULL.  In this case,
kstrdup returns NULL (because it was passed NULL parameter), although no
out of memory condition exists.  The mount syscall then fails with
ENOMEM.

This patch fixes the bug.  We fail with ENOMEM only if data is non-NULL.

The patch also changes the call to replace_mount_options - if we didn't
pass any filesystem-specific options, we don't call
replace_mount_options (thus we don't erase existing reported options).

Fixes: ce657611 ("hpfs: kstrdup() out of memory handling")
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Cc: stable@vger.kernel.org
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 4029632c

fs/hpfs/super.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -455,7 +455,7 @@ static int hpfs_remount_fs(struct super_block s, int flags, char *data)
		struct hpfs_sb_info *sbi = hpfs_sb(s);
		char *new_opts = kstrdup(data, GFP_KERNEL);

		if (!new_opts)
		if (data && !new_opts)
		return -ENOMEM;

		sync_filesystem(s);
		@@ -493,6 +493,7 @@ static int hpfs_remount_fs(struct super_block s, int flags, char *data)

		if (!(*flags & MS_RDONLY)) mark_dirty(s, 1);

		if (new_opts)
		replace_mount_options(s, new_opts);

		hpfs_unlock(s);

Admin message