Commit 3dc857f0 authored Mar 17, 2017 by David Ahern Committed by David S. Miller Mar 21, 2017

net: vrf: Reset rt6i_idev in local dst after put

The VRF driver takes a reference to the inet6_dev on the VRF device for
its rt6_local dst when handling local traffic through the VRF device as
a loopback. When the device is deleted the driver does a put on the idev
but does not reset rt6i_idev in the rt6_info struct. When the dst is
destroyed, dst_destroy calls ip6_dst_destroy which does a second put for
what is essentially the same reference causing it to be prematurely freed.
Reset rt6i_idev after the put in the vrf driver.

Fixes: b4869aa2 ("net: vrf: ipv6 support for local traffic to
local addresses")
Signed-off-by: David Ahern <dsa@cumulusnetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 13e2d518

drivers/net/vrf.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -462,8 +462,10 @@ static void vrf_rt6_release(struct net_device dev, struct net_vrf vrf)
		}

		if (rt6_local) {
		if (rt6_local->rt6i_idev)
		if (rt6_local->rt6i_idev) {
		in6_dev_put(rt6_local->rt6i_idev);
		rt6_local->rt6i_idev = NULL;
		}

		dst = &rt6_local->dst;
		dev_put(dst->dev);

Admin message