Commit 13e2d518 authored Mar 17, 2017 by Dan Carpenter Committed by David S. Miller Mar 21, 2017

bna: integer overflow bug in debugfs



We could allocate less memory than intended because we do:

	bnad->regdata = kzalloc(len << 2, GFP_KERNEL);

The shift can overflow leading to a crash.  This is debugfs code so the
impact is very small.

Fixes: 7afc5dbd ("bna: Add debugfs interface.")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Rasesh Mody <rasesh.mody@cavium.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 6bd845d1

drivers/net/ethernet/brocade/bna/bnad_debugfs.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -325,7 +325,7 @@ bnad_debugfs_write_regrd(struct file file, const char __user buf,
		return PTR_ERR(kern_buf);

		rc = sscanf(kern_buf, "%x:%x", &addr, &len);
		if (rc < 2) {
		if (rc < 2 \|\| len > UINT_MAX >> 2) {
		netdev_warn(bnad->netdev, "failed to read user buffer\n");
		kfree(kern_buf);
		return -EINVAL;

Admin message