Commit 38cd989e authored Nov 13, 2018 by Nicolin Chen Committed by Guenter Roeck Nov 14, 2018

hwmon: (ina2xx) Fix current value calculation



The current register (04h) has a sign bit at MSB. The comments
for this calculation also mention that it's a signed register.

However, the regval is unsigned type so result of calculation
turns out to be an incorrect value when current is negative.

This patch simply fixes this by adding a casting to s16.

Fixes: 5d389b12 ("hwmon: (ina2xx) Make calibration register value fixed")
Signed-off-by: Nicolin Chen <nicoleotsuka@gmail.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

parent 35fdc390

drivers/hwmon/ina2xx.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -274,7 +274,7 @@ static int ina2xx_get_value(struct ina2xx_data *data, u8 reg,
		break;
		case INA2XX_CURRENT:
		/* signed register, result in mA */
		val = regval * data->current_lsb_uA;
		val = (s16)regval * data->current_lsb_uA;
		val = DIV_ROUND_CLOSEST(val, 1000);
		break;
		case INA2XX_CALIBRATION:

Admin message