hwmon: (raspberrypi) Fix initial notify (35fdc390) · Commits · 戴 / test

In case an under-voltage happens before probing the driver wont write the critical warning into the kernel log. So don't init of last_throttled during probe and fix this issue. Fixes: ("hwmon: Add support for RPi voltage sensor") Reported-by:

"Noralf Trønnes" <noralf@tronnes.org> Signed-off-by:

Stefan Wahren <stefan.wahren@i2se.com> Signed-off-by:

Guenter Roeck <linux@roeck-us.net>

drivers/hwmon/raspberrypi-hwmon.c

+0 −6

Original line number	Diff line number	Diff line
		@@ -115,7 +115,6 @@ static int rpi_hwmon_probe(struct platform_device *pdev)
		{
		struct device *dev = &pdev->dev;
		struct rpi_hwmon_data *data;
		int ret;

		data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL);
		if (!data)
		@@ -124,11 +123,6 @@ static int rpi_hwmon_probe(struct platform_device *pdev)
		/* Parent driver assure that firmware is correct */
		data->fw = dev_get_drvdata(dev->parent);

		/* Init throttled */
		ret = rpi_firmware_property(data->fw, RPI_FIRMWARE_GET_THROTTLED,
		&data->last_throttled,
		sizeof(data->last_throttled));

		data->hwmon_dev = devm_hwmon_device_register_with_info(dev, "rpi_volt",
		data,
		&rpi_chip_info,

Admin message