Commit 3662cd19 authored Apr 08, 2020 by Thomas Zimmermann

drm/vboxvideo: Set up fbdev after registering device; remove error checks



Generic fbdev support is a DRM client. Set it up after registering
the new DRM device. Remove the error checks as the driver's probe
function should not depend on a DRM client's state.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Noralf Trønnes <noralf@tronnes.org>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
Acked-by: Gerd Hoffmann <kraxel@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200408082641.590-10-tzimmermann@suse.de

parent 66459fa2

drivers/gpu/drm/vboxvideo/vbox_drv.c

+2 −4

Original line number	Diff line number	Diff line
		@@ -78,14 +78,12 @@ static int vbox_pci_probe(struct pci_dev pdev, const struct pci_device_id ent)
		if (ret)
		goto err_mode_fini;

		ret = drm_fbdev_generic_setup(&vbox->ddev, 32);
		if (ret)
		goto err_irq_fini;

		ret = drm_dev_register(&vbox->ddev, 0);
		if (ret)
		goto err_irq_fini;

		drm_fbdev_generic_setup(&vbox->ddev, 32);

		return 0;

		err_irq_fini:

Admin message