Commit 66459fa2 authored Apr 08, 2020 by Thomas Zimmermann

drm/udl: Remove error check from fbdev setup



Remove the error check from the fbdev setup function. The driver's
probe function should not depend on a DRM client's state.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Noralf Trønnes <noralf@tronnes.org>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
Acked-by: Gerd Hoffmann <kraxel@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200408082641.590-9-tzimmermann@suse.de

parent f5ef0762

drivers/gpu/drm/udl/udl_drv.c

+1 −5

Original line number	Diff line number	Diff line
		@@ -97,14 +97,10 @@ static int udl_usb_probe(struct usb_interface *interface,

		DRM_INFO("Initialized udl on minor %d\n", udl->drm.primary->index);

		r = drm_fbdev_generic_setup(&udl->drm, 0);
		if (r)
		goto err_drm_dev_unregister;
		drm_fbdev_generic_setup(&udl->drm, 0);

		return 0;

		err_drm_dev_unregister:
		drm_dev_unregister(&udl->drm);
		err_free:
		drm_dev_put(&udl->drm);
		return r;

Admin message