Commit 35d600dd authored by Jordan Crouse's avatar Jordan Crouse Committed by Rob Clark
Browse files

drm/msm/dpu: Remove dpu_crtc_get_mixer_height 



dpu_crtc_get_mixer_height() is only used once and the value it
returns can be easily derived from the calling function.

v3: No changes

Reviewed-by: default avatarSean Paul <sean@poorly.run>
Signed-off-by: default avatarJordan Crouse <jcrouse@codeaurora.org>
Signed-off-by: default avatarSean Paul <seanpaul@chromium.org>
Signed-off-by: default avatarRob Clark <robdclark@gmail.com>
parent 27bc773a

drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c

+1 −2
Original line number Diff line number Diff line
@@ -495,7 +495,6 @@ static void _dpu_crtc_setup_mixers(struct drm_crtc *crtc) 
static void _dpu_crtc_setup_lm_bounds(struct drm_crtc *crtc,

		struct drm_crtc_state *state)

{

	struct dpu_crtc *dpu_crtc = to_dpu_crtc(crtc);

	struct dpu_crtc_state *cstate = to_dpu_crtc_state(state);

	struct drm_display_mode *adj_mode = &state->adjusted_mode;

	u32 crtc_split_width = _dpu_crtc_get_mixer_width(cstate, adj_mode);
@@ -506,7 +505,7 @@ static void _dpu_crtc_setup_lm_bounds(struct drm_crtc *crtc, 
		r->x1 = crtc_split_width * i;

		r->y1 = 0;

		r->x2 = r->x1 + crtc_split_width;

		r->y2 = dpu_crtc_get_mixer_height(dpu_crtc, cstate, adj_mode);

		r->y2 = adj_mode->vdisplay;



		trace_dpu_crtc_setup_lm_bounds(DRMID(crtc), i, r);

	}

drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h

+0 −13
Original line number Diff line number Diff line
@@ -236,19 +236,6 @@ static inline bool dpu_crtc_state_is_stereo(struct dpu_crtc_state *cstate) 
	return cstate->num_mixers == CRTC_DUAL_MIXERS;

}



/**

 * dpu_crtc_get_mixer_height - get the mixer height

 * Mixer height will be same as panel height

 */

static inline int dpu_crtc_get_mixer_height(struct dpu_crtc *dpu_crtc,

		struct dpu_crtc_state *cstate, struct drm_display_mode *mode)

{

	if (!dpu_crtc || !cstate || !mode)

		return 0;



	return mode->vdisplay;

}



/**

 * dpu_crtc_frame_pending - retun the number of pending frames

 * @crtc: Pointer to drm crtc object

CRA Git | Maintained and supported by SUSTech CRA and CCSE