rtc: pcf8563: Clear event flags and disable interrupts before requesting irq (3572e8ae) · Commits · 戴 / test

Besides the alarm, the PCF8563 also has a timer triggered interrupt. In cases where the previous system left the timer and interrupts on, or somehow the bits got enabled, the interrupt would keep triggering as the kernel doesn't know about it. Clear both the alarm and timer event flags, and disable the interrupts, before requesting the interrupt line. Fixes: ("drivers/rtc/rtc-pcf8563.c: add alarm support") Fixes: ("rtc: pcf8563: clear expired alarm at boot time") Signed-off-by:

Chen-Yu Tsai <wens@csie.org> Signed-off-by:

Alexandre Belloni <alexandre.belloni@bootlin.com>

drivers/rtc/rtc-pcf8563.c

+5 −6

Original line number	Diff line number	Diff line
		@@ -563,7 +563,6 @@ static int pcf8563_probe(struct i2c_client *client,
		struct pcf8563 *pcf8563;
		int err;
		unsigned char buf;
		unsigned char alm_pending;

		dev_dbg(&client->dev, "%s\n", __func__);

		@@ -587,13 +586,13 @@ static int pcf8563_probe(struct i2c_client *client,
		return err;
		}

		err = pcf8563_get_alarm_mode(client, NULL, &alm_pending);
		if (err) {
		dev_err(&client->dev, "%s: read error\n", __func__);
		/* Clear flags and disable interrupts */
		buf = 0;
		err = pcf8563_write_block_data(client, PCF8563_REG_ST2, 1, &buf);
		if (err < 0) {
		dev_err(&client->dev, "%s: write error\n", __func__);
		return err;
		}
		if (alm_pending)
		pcf8563_set_alarm_mode(client, 0);

		pcf8563->rtc = devm_rtc_device_register(&client->dev,
		pcf8563_driver.driver.name,

Admin message