Commit 343dfaa1 authored Dec 06, 2016 by Florian Westphal Committed by David S. Miller Dec 06, 2016

Revert "dctcp: update cwnd on congestion event"



Neal Cardwell says:
 If I am reading the code correctly, then I would have two concerns:
 1) Has that been tested? That seems like an extremely dramatic
    decrease in cwnd. For example, if the cwnd is 80, and there are 40
    ACKs, and half the ACKs are ECE marked, then my back-of-the-envelope
    calculations seem to suggest that after just 11 ACKs the cwnd would be
    down to a minimal value of 2 [..]
 2) That seems to contradict another passage in the draft [..] where it
    sazs:
       Just as specified in [RFC3168], DCTCP does not react to congestion
       indications more than once for every window of data.

Neal is right.  Fortunately we don't have to complicate this by testing
vs. current rtt estimate, we can just revert the patch.

Normal stack already handles this for us: receiving ACKs with ECE
set causes a call to tcp_enter_cwr(), from there on the ssthresh gets
adjusted and prr will take care of cwnd adjustment.

Fixes: 47805667 ("dctcp: update cwnd on congestion event")
Cc: Neal Cardwell <ncardwell@google.com>
Signed-off-by: Florian Westphal <fw@strlen.de>
Acked-by: Neal Cardwell <ncardwell@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent b1df0f5c

net/ipv4/tcp_dctcp.c

+1 −8

Original line number	Diff line number	Diff line
		@@ -188,8 +188,8 @@ static void dctcp_ce_state_1_to_0(struct sock *sk)

		static void dctcp_update_alpha(struct sock *sk, u32 flags)
		{
		const struct tcp_sock *tp = tcp_sk(sk);
		struct dctcp *ca = inet_csk_ca(sk);
		struct tcp_sock *tp = tcp_sk(sk);
		u32 acked_bytes = tp->snd_una - ca->prior_snd_una;

		/* If ack did not advance snd_una, count dupack as MSS size.
		@@ -229,13 +229,6 @@ static void dctcp_update_alpha(struct sock *sk, u32 flags)
		WRITE_ONCE(ca->dctcp_alpha, alpha);
		dctcp_reset(tp, ca);
		}

		if (flags & CA_ACK_ECE) {
		unsigned int cwnd = dctcp_ssthresh(sk);

		if (cwnd != tp->snd_cwnd)
		tp->snd_cwnd = cwnd;
		}
		}

		static void dctcp_state(struct sock *sk, u8 new_state)

Admin message