Commit 314a8ad0 authored Sep 30, 2013 by Oleg Nesterov Committed by Linus Torvalds Sep 30, 2013

pidns: fix free_pid() to handle the first fork failure



"case 0" in free_pid() assumes that disable_pid_allocation() should
clear PIDNS_HASH_ADDING before the last pid goes away.

However this doesn't happen if the first fork() fails to create the
child reaper which should call disable_pid_allocation().

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Reviewed-by: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: "Serge E. Hallyn" <serge@hallyn.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 4271b05a

kernel/pid.c

+5 −0

Original line number	Diff line number	Diff line
		@@ -273,6 +273,11 @@ void free_pid(struct pid *pid)
		*/
		wake_up_process(ns->child_reaper);
		break;
		case PIDNS_HASH_ADDING:
		/* Handle a fork failure of the first process */
		WARN_ON(ns->child_reaper);
		ns->nr_hashed = 0;
		/* fall through */
		case 0:
		schedule_work(&ns->proc_work);
		break;

Admin message