Commit 4271b05a authored Sep 30, 2013 by Davidlohr Bueso Committed by Linus Torvalds Sep 30, 2013

ipc,msg: prevent race with rmid in msgsnd,msgrcv



This fixes a race in both msgrcv() and msgsnd() between finding the msg
and actually dealing with the queue, as another thread can delete shmid
underneath us if we are preempted before acquiring the
kern_ipc_perm.lock.

Manfred illustrates this nicely:

Assume a preemptible kernel that is preempted just after

    msq = msq_obtain_object_check(ns, msqid)

in do_msgrcv().  The only lock that is held is rcu_read_lock().

Now the other thread processes IPC_RMID.  When the first task is
resumed, then it will happily wait for messages on a deleted queue.

Fix this by checking for if the queue has been deleted after taking the
lock.

Signed-off-by: Davidlohr Bueso <davidlohr@hp.com>
Reported-by: Manfred Spraul <manfred@colorfullife.com>
Cc: Rik van Riel <riel@redhat.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: <stable@vger.kernel.org> 	[3.11]
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 0e8c6656

ipc/msg.c

+13 −0

Original line number	Diff line number	Diff line
		@@ -695,6 +695,12 @@ long do_msgsnd(int msqid, long mtype, void __user *mtext,
		if (ipcperms(ns, &msq->q_perm, S_IWUGO))
		goto out_unlock0;

		/* raced with RMID? */
		if (msq->q_perm.deleted) {
		err = -EIDRM;
		goto out_unlock0;
		}

		err = security_msg_queue_msgsnd(msq, msg, msgflg);
		if (err)
		goto out_unlock0;
		@@ -901,6 +907,13 @@ long do_msgrcv(int msqid, void __user *buf, size_t bufsz, long msgtyp, int msgfl
		goto out_unlock1;

		ipc_lock_object(&msq->q_perm);

		/* raced with RMID? */
		if (msq->q_perm.deleted) {
		msg = ERR_PTR(-EIDRM);
		goto out_unlock0;
		}

		msg = find_msg(msq, &msgtyp, mode);
		if (!IS_ERR(msg)) {
		/*

Admin message