Commit 30a8beeb authored Jul 31, 2019 by Tomas Bortoli Committed by Marc Kleine-Budde Aug 02, 2019

can: peak_usb: pcan_usb_fd: Fix info-leaks to USB devices



Uninitialized Kernel memory can leak to USB devices.

Fix by using kzalloc() instead of kmalloc() on the affected buffers.

Signed-off-by: Tomas Bortoli <tomasbortoli@gmail.com>
Reported-by:  <syzbot+513e4d0985298538bf9b@syzkaller.appspotmail.com>
Fixes: 0a25e1f4 ("can: peak_usb: add support for PEAK new CANFD USB adapters")
Cc: linux-stable <stable@vger.kernel.org>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>

parent e787f193

drivers/net/can/usb/peak_usb/pcan_usb_fd.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -841,7 +841,7 @@ static int pcan_usb_fd_init(struct peak_usb_device *dev)
		goto err_out;

		/* allocate command buffer once for all for the interface */
		pdev->cmd_buffer_addr = kmalloc(PCAN_UFD_CMD_BUFFER_SIZE,
		pdev->cmd_buffer_addr = kzalloc(PCAN_UFD_CMD_BUFFER_SIZE,
		GFP_KERNEL);
		if (!pdev->cmd_buffer_addr)
		goto err_out_1;

Admin message