Commit 3084db0e authored Nov 02, 2020 by Daniel Latypov Committed by Shuah Khan Nov 10, 2020

kunit: fix display of failed expectations for strings



Currently the following expectation
  KUNIT_EXPECT_STREQ(test, "hi", "bye");
will produce:
  Expected "hi" == "bye", but
      "hi" == 1625079497
      "bye" == 1625079500

After this patch:
  Expected "hi" == "bye", but
      "hi" == hi
      "bye" == bye

KUNIT_INIT_BINARY_STR_ASSERT_STRUCT() was written but just mistakenly
not actually used by KUNIT_EXPECT_STREQ() and friends.

Signed-off-by: Daniel Latypov <dlatypov@google.com>
Reviewed-by: Brendan Higgins <brendanhiggins@google.com>
Tested-by: Brendan Higgins <brendanhiggins@google.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>

parent 060352e1

include/kunit/test.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -1105,7 +1105,7 @@ do { \
		KUNIT_ASSERTION(test, \
		strcmp(__left, __right) op 0, \
		kunit_binary_str_assert, \
		KUNIT_INIT_BINARY_ASSERT_STRUCT(test, \
		KUNIT_INIT_BINARY_STR_ASSERT_STRUCT(test, \
		assert_type, \
		#op, \
		#left, \

Admin message