Commit 060352e1 authored Oct 30, 2020 by Daniel Latypov Committed by Shuah Khan Nov 10, 2020

kunit: tool: fix extra trailing \n in raw + parsed test output

For simplcity, strip all trailing whitespace from parsed output.
I imagine no one is printing out meaningful trailing whitespace via
KUNIT_FAIL() or similar, and that if they are, they really shouldn't.

`isolate_kunit_output()` yielded liens with trailing \n, which results
in artifacty output like this:

$ ./tools/testing/kunit/kunit.py run
[16:16:46] [FAILED] example_simple_test
[16:16:46]     # example_simple_test: EXPECTATION FAILED at lib/kunit/kunit-example-test.c:29

[16:16:46]     Expected 1 + 1 == 3, but

[16:16:46]         1 + 1 == 2

[16:16:46]         3 == 3

[16:16:46]     not ok 1 - example_simple_test

[16:16:46]

After this change:
[16:16:46]     # example_simple_test: EXPECTATION FAILED at lib/kunit/kunit-example-test.c:29
[16:16:46]     Expected 1 + 1 == 3, but
[16:16:46]         1 + 1 == 2
[16:16:46]         3 == 3
[16:16:46]     not ok 1 - example_simple_test
[16:16:46]

We should *not* be expecting lines to end with \n in kunit_tool_test.py
for this reason.

Do the same for `raw_output()` as well which suffers from the same
issue.

This is a followup to [1], but rebased onto kunit-fixes to pick up the
other raw_output() fix and fixes for kunit_tool_test.py.

[1] https://lore.kernel.org/linux-kselftest/20201020233219.4146059-1-dlatypov@google.com/



Signed-off-by: Daniel Latypov <dlatypov@google.com>
Reviewed-by: David Gow <davidgow@google.com>
Tested-by: David Gow <davidgow@google.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>

parent 39088144

tools/testing/kunit/kunit_parser.py

+2 −1

Original line number	Diff line number	Diff line
		@@ -54,6 +54,7 @@ kunit_end_re = re.compile('(List of all partitions:\|'
		def isolate_kunit_output(kernel_output):
		started = False
		for line in kernel_output:
		line = line.rstrip() # line always has a trailing \n
		if kunit_start_re.search(line):
		prefix_len = len(line.split('TAP version')[0])
		started = True
		@@ -65,7 +66,7 @@ def isolate_kunit_output(kernel_output):

		def raw_output(kernel_output):
		for line in kernel_output:
		print(line)
		print(line.rstrip())

		DIVIDER = '=' * 60

tools/testing/kunit/kunit_tool_test.py

+2 −2

Original line number	Diff line number	Diff line
		@@ -102,7 +102,7 @@ class KUnitParserTest(unittest.TestCase):
		'test_data/test_output_isolated_correctly.log')
		file = open(log_path)
		result = kunit_parser.isolate_kunit_output(file.readlines())
		self.assertContains('TAP version 14\n', result)
		self.assertContains('TAP version 14', result)
		self.assertContains(' # Subtest: example', result)
		self.assertContains(' 1..2', result)
		self.assertContains(' ok 1 - example_simple_test', result)
		@@ -115,7 +115,7 @@ class KUnitParserTest(unittest.TestCase):
		'test_data/test_pound_sign.log')
		with open(log_path) as file:
		result = kunit_parser.isolate_kunit_output(file.readlines())
		self.assertContains('TAP version 14\n', result)
		self.assertContains('TAP version 14', result)
		self.assertContains(' # Subtest: kunit-resource-test', result)
		self.assertContains(' 1..5', result)
		self.assertContains(' ok 1 - kunit_resource_test_init_resources', result)

Admin message