Commit 2fcf5335 authored Mar 27, 2020 by afzal mohammed Committed by Arnd Bergmann Mar 27, 2020

ARM: mmp: replace setup_irq() by request_irq()

request_irq() is preferred over setup_irq(). Invocations of setup_irq()
occur after memory allocators are ready.

Per tglx[1], setup_irq() existed in olden days when allocators were not
ready by the time early interrupts were initialized.

Hence replace setup_irq() by request_irq().

[1] https://lkml.kernel.org/r/alpine.DEB.2.20.1710191609480.1971@nanos

Link: https://lore.kernel.org/r/20200327124437.4239-1-afzal.mohd.ma@gmail.com


Signed-off-by: afzal mohammed <afzal.mohd.ma@gmail.com>
Acked-by: Lubomir Rintel <lkundrak@v3.sk>
Tested-by: Lubomir Rintel <lkundrak@v3.sk>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>

parent 4c819924

arch/arm/mach-mmp/time.c

+3 −8

Original line number	Diff line number	Diff line
		@@ -175,13 +175,6 @@ static void __init timer_config(void)
		__raw_writel(0x2, mmp_timer_base + TMR_CER);
		}

		static struct irqaction timer_irq = {
		.name = "timer",
		.flags = IRQF_TIMER \| IRQF_IRQPOLL,
		.handler = timer_interrupt,
		.dev_id = &ckevt,
		};

		void __init mmp_timer_init(int irq, unsigned long rate)
		{
		timer_config();
		@@ -190,7 +183,9 @@ void __init mmp_timer_init(int irq, unsigned long rate)

		ckevt.cpumask = cpumask_of(0);

		setup_irq(irq, &timer_irq);
		if (request_irq(irq, timer_interrupt, IRQF_TIMER \| IRQF_IRQPOLL,
		"timer", &ckevt))
		pr_err("Failed to request irq %d (timer)\n", irq);

		clocksource_register_hz(&cksrc, rate);
		clockevents_config_and_register(&ckevt, rate, MIN_DELTA, MAX_DELTA);

Admin message