Commit 4c819924 authored by afzal mohammed's avatar afzal mohammed Committed by Arnd Bergmann
Browse files

ARM: cns3xxx: replace setup_irq() by request_irq() 

request_irq() is preferred over setup_irq(). Invocations of setup_irq()
occur after memory allocators are ready.

Per tglx[1], setup_irq() existed in olden days when allocators were not
ready by the time early interrupts were initialized.

Hence replace setup_irq() by request_irq().

[1] https://lkml.kernel.org/r/alpine.DEB.2.20.1710191609480.1971@nanos

Link: https://lore.kernel.org/r/20200327124422.4181-1-afzal.mohd.ma@gmail.com


Signed-off-by: default avatarafzal mohammed <afzal.mohd.ma@gmail.com>
Acked-by: default avatarKrzysztof Halasa <khalasa@piap.pl>
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
parent c84e4899

arch/arm/mach-cns3xxx/core.c

+3 −7
Original line number Diff line number Diff line
@@ -189,12 +189,6 @@ static irqreturn_t cns3xxx_timer_interrupt(int irq, void *dev_id) 
	return IRQ_HANDLED;

}



static struct irqaction cns3xxx_timer_irq = {

	.name		= "timer",

	.flags		= IRQF_TIMER | IRQF_IRQPOLL,

	.handler	= cns3xxx_timer_interrupt,

};



/*

 * Set up the clock source and clock events devices

 */
@@ -245,7 +239,9 @@ static void __init __cns3xxx_timer_init(unsigned int timer_irq) 
	writel(val, cns3xxx_tmr1 + TIMER1_2_CONTROL_OFFSET);



	/* Make irqs happen for the system timer */

	setup_irq(timer_irq, &cns3xxx_timer_irq);

	if (request_irq(timer_irq, cns3xxx_timer_interrupt,

			IRQF_TIMER | IRQF_IRQPOLL, "timer", NULL))

		pr_err("Failed to request irq %d (timer)\n", timer_irq);



	cns3xxx_clockevents_init(timer_irq);

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE