Commit 2e7e9758 authored by David Howells's avatar David Howells
Browse files

rxrpc: Once packet posted in data_ready, don't retry posting 



Once a packet has been posted to a connection in the data_ready handler, we
mustn't try reposting if we then find that the connection is dying as the
refcount has been given over to the dying connection and the packet might
no longer exist.

Losing the packet isn't a problem as the peer will retransmit.

Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
parent f9dc5757

net/rxrpc/input.c

+3 −5
Original line number Diff line number Diff line
@@ -567,13 +567,13 @@ done: 
 * post connection-level events to the connection

 * - this includes challenges, responses and some aborts

 */

static bool rxrpc_post_packet_to_conn(struct rxrpc_connection *conn,

static void rxrpc_post_packet_to_conn(struct rxrpc_connection *conn,

				      struct sk_buff *skb)

{

	_enter("%p,%p", conn, skb);



	skb_queue_tail(&conn->rx_queue, skb);

	return rxrpc_queue_conn(conn);

	rxrpc_queue_conn(conn);

}



/*
@@ -694,7 +694,6 @@ void rxrpc_data_ready(struct sock *sk) 


	rcu_read_lock();



retry_find_conn:

	conn = rxrpc_find_connection_rcu(local, skb);

	if (!conn)

		goto cant_route_call;
@@ -702,8 +701,7 @@ retry_find_conn: 
	if (sp->hdr.callNumber == 0) {

		/* Connection-level packet */

		_debug("CONN %p {%d}", conn, conn->debug_id);

		if (!rxrpc_post_packet_to_conn(conn, skb))

			goto retry_find_conn;

		rxrpc_post_packet_to_conn(conn, skb);

	} else {

		/* Call-bound packets are routed by connection channel. */

		unsigned int channel = sp->hdr.cid & RXRPC_CHANNELMASK;

CRA Git | Maintained and supported by SUSTech CRA and CCSE