Commit f9dc5757 authored Aug 08, 2016 by David Howells

rxrpc: Don't access connection from call if pointer is NULL



The call state machine processor sets up the message parameters for a UDP
message that it might need to transmit in advance on the basis that there's
a very good chance it's going to have to transmit either an ACK or an
ABORT.  This requires it to look in the connection struct to retrieve some
of the parameters.

However, if the call is complete, the call connection pointer may be NULL
to dissuade the processor from transmitting a message.  However, there are
some situations where the processor is still going to be called - and it's
still going to set up message parameters whether it needs them or not.

This results in a NULL pointer dereference at:

	net/rxrpc/call_event.c:837

To fix this, skip the message pre-initialisation if there's no connection
attached.

Signed-off-by: David Howells <dhowells@redhat.com>

parent 17b963e3

net/rxrpc/call_event.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -837,6 +837,9 @@ void rxrpc_process_call(struct work_struct *work)
		return;
		}

		if (!call->conn)
		goto skip_msg_init;

		/* there's a good chance we're going to have to send a message, so set
		* one up in advance */
		msg.msg_name = &call->conn->params.peer->srx.transport;
		@@ -859,6 +862,7 @@ void rxrpc_process_call(struct work_struct *work)
		memset(iov, 0, sizeof(iov));
		iov[0].iov_base = &whdr;
		iov[0].iov_len = sizeof(whdr);
		skip_msg_init:

		/* deal with events of a final nature */
		if (test_bit(RXRPC_CALL_EV_RCVD_ERROR, &call->events)) {

Admin message