scsi: qedi: Avoid unnecessary endpoint allocation on link down (2e612fab) · Commits · 戴 / test

No need to allocate and deallocate endpoint memory if the physical link is down. Link: https://lore.kernel.org/r/20200408064332.19377-3-mrangankar@marvell.com Reviewed-by:

drivers/scsi/qedi/qedi_iscsi.c

+5 −6

Original line number	Diff line number	Diff line
		@@ -836,6 +836,11 @@ qedi_ep_connect(struct Scsi_Host shost, struct sockaddr dst_addr,
		return ERR_PTR(ret);
		}

		if (atomic_read(&qedi->link_state) != QEDI_LINK_UP) {
		QEDI_WARN(&qedi->dbg_ctx, "qedi link down\n");
		return ERR_PTR(-ENXIO);
		}

		ep = iscsi_create_endpoint(sizeof(struct qedi_endpoint));
		if (!ep) {
		QEDI_ERR(&qedi->dbg_ctx, "endpoint create fail\n");
		@@ -870,12 +875,6 @@ qedi_ep_connect(struct Scsi_Host shost, struct sockaddr dst_addr,
		QEDI_ERR(&qedi->dbg_ctx, "Invalid endpoint\n");
		}

		if (atomic_read(&qedi->link_state) != QEDI_LINK_UP) {
		QEDI_WARN(&qedi->dbg_ctx, "qedi link down\n");
		ret = -ENXIO;
		goto ep_conn_exit;
		}

		ret = qedi_alloc_sq(qedi, qedi_ep);
		if (ret)
		goto ep_conn_exit;