Commit 2f1ea398 authored Apr 07, 2020 by Manish Rangankar Committed by Martin K. Petersen Apr 13, 2020

scsi: qedi: Remove additional char from boot target iqnname

While parsing the iSCSI TLV data to MFW request, a newline was added to the
firmware boot target iqnname string. Because of this, we were getting the
following error even after the boot target was successfully logged in:

"[qedi_get_protocol_tlv_data:1197]:1: Boot target not set"

Remove the trailing newline.

[mkp: clarified commit desc]

Link: https://lore.kernel.org/r/20200408064332.19377-2-mrangankar@marvell.com


Reviewed-by: Lee Duncan <lduncan@suse.com>
Signed-off-by: Manish Rangankar <mrangankar@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent fbbef0da

drivers/scsi/qedi/qedi_main.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -921,7 +921,7 @@ static void qedi_get_boot_tgt_info(struct nvm_iscsi_block *block,
		ipv6_en = !!(block->generic.ctrl_flags &
		NVM_ISCSI_CFG_GEN_IPV6_ENABLED);

		snprintf(tgt->iscsi_name, sizeof(tgt->iscsi_name), "%s\n",
		snprintf(tgt->iscsi_name, sizeof(tgt->iscsi_name), "%s",
		block->target[index].target_name.byte);

		tgt->ipv6_en = ipv6_en;

Admin message