Commit 2d35526d authored May 22, 2019 by Pierre-Louis Bossart Committed by Vinod Koul May 27, 2019

soundwire: cadence_master: check the number of bidir PDIs



There is an assumption that the first two PDIs are reserved for Bulk,
so we need to make sure the number of bidir PDIs is indeed larger than
two. If the configuration provided is incorrect, this could lead to
allocating a huge amount of memory.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Signed-off-by: Vinod Koul <vkoul@kernel.org>

parent a78b32d9

drivers/soundwire/cadence_master.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -718,6 +718,8 @@ int sdw_cdns_pdi_init(struct sdw_cdns *cdns,
		stream = &cdns->pcm;

		/* First two PDIs are reserved for bulk transfers */
		if (stream->num_bd < CDNS_PCM_PDI_OFFSET)
		return -EINVAL;
		stream->num_bd -= CDNS_PCM_PDI_OFFSET;
		offset = CDNS_PCM_PDI_OFFSET;

Admin message